Conversation
Add chronicle.lua fortress chronicle script
Add chronicle.lua fortress chronicle script
Fix chronicle year_tick and re-enable hooks
…ck-error Fix chronicle artifact timestamp
Disable heavy scanning in chronicle
Add artifact and invasion tracking to chronicle
Tie holy-war to deity spheres and grudges
…t-issues Add empty chronicle notice and item creation events
Fix holy-war mutual war
…nce-error Fix chronicle UTF-8 issues
Enhance holy-war output
Summarize non-artifact item creation
Fix holy-war output for unnamed civs
Fix multihaul autowheelbarrows
…arch-functions-in-multhaul Refactor multihaul item search
And limited wheelbarrow search radius for the sake of performance
|
If there is a better way to cycle through items than my for_each_item_in_radius — please let me know |
…bs_without_wheelbarrow-helper Add multihaul job cleanup helper
…-in-multihaul.lua Fix multihaul forward declaration
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
chdoc
left a comment
chdoc
left a comment
There was a problem hiding this comment.
First of all, I think this is a very interesting idea 👍
This pull-request contains a whopping 139 commits, many of them are merge-commits and/or completely unrelated to the thing you are trying to add. If you want to preserve your own local history, that is fine, but please create pull-requests from cleaned-up branches containing only commits pertaining to the feature being added, preferably a single commit at the point where the pull-request is created.
I haven't looked in detail at the actual code. At first glance, it looks pretty reasonable. I will take a more detailed look, once the commit history has been cleaned up.
docs/multihaul.rst
Outdated
|
|
||
| .. dfhack-tool:: | ||
| :summary: Haulers gather multiple nearby items when using wheelbarrows. | ||
| :tags: fort productivity items stockpile |
There was a problem hiding this comment.
Since this actually changes gameplay mechanics rather than just automating existing mechanics, I think this should be gameplay rather than productivity.
There was a problem hiding this comment.
Okay, would change it if you think it would fit it better
| they can be hauled in a single trip. Jobs without wheelbarrows would try to attach one if autowheelbarrows option is on. | ||
| Items claimed by another jobs or already stored in stockpiles would be ignored. | ||
| By default, up to ten additional items within 10 tiles of the original item are collected. | ||
| Warning: Destination stockpile filters are currently ignored by the job (because of DF logic). Which items qualify can be controlled |
There was a problem hiding this comment.
I think it would be highly desirable for the tool to respect the stockpile settings. Can you elaborate on what the issue is?
There was a problem hiding this comment.
I haven't found any way to check and use stockpile filters, so it is impossible to implement that, sadly
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
please squash this and force push. i am not reviewing a 142-commit PR |
3 participants
This tool allows dwarves to collect several adjacent items at once when performing hauling jobs with a wheelbarrow. When enabled, new
StoreItemInStockpilejobs will automatically attach nearby items so they can be hauled in a single trip.Items claimed by another jobs would be ignored. The script only triggers when a wheelbarrow is definitively attached to the job. By default, up to ten additional items within 10 tiles of the original item are collected.
--modeoption.P.S.: this is my first attempt on committing anything to a big project, so I would appreciate patience and guidance :)